[rush-lib] Normalize plugin autoinstaller file line endings#5678
Merged
octogonz merged 1 commit intomicrosoft:mainfrom Mar 4, 2026
Merged
Conversation
Made-with: Cursor
kevin-y-ang
requested review from
apostolisms,
bmiddha,
dmichon-msft,
iclanton,
jxanthony and
octogonz
as code owners
octogonz
reviewed
Mar 3, 2026
libraries/rush-lib/src/pluginFramework/PluginLoader/AutoinstallerPluginLoader.ts
Show resolved
Hide resolved
octogonz
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoinstallerPluginLoader.tsto read source JSON files and write them withconvertLineEndings: NewlineKind.Lf.Details
AutoinstallerPluginLoader.tswill the line endings ofrush-plugin-manifest.jsonandcommand-line.json. This creates unstaged changes that causes confusion and inconvenience for developers.FileSystem.copyFile()does not support the optionconvertLineEndings: NewlineKind.Lf. This problem can be resolved by reading the file into memory withFileSystem.readFile()and writing it withFileSystem.writeFile()with theconvertLineEndings: NewlineKind.Lfoption.How it was tested
rush-plugin-manifest.jsonandcommand-line.jsonwhen running rush update.